fix(e2e): fallback for binaries that don't have --versions support yet #7110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
no release notes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a fallback for retrieving the Chromium version from binaries that don’t support the --versions flag yet.
- Wraps the JSON parsing of
stdoutin atry/catchblock. - Returns
MONOREPO_ELECTRON_CHROMIUM_VERSIONif parsing fails.
Comments suppressed due to low confidence (2)
packages/compass-e2e-tests/helpers/compass.ts:481
- Add a unit test to cover the fallback path where JSON.parse fails and
MONOREPO_ELECTRON_CHROMIUM_VERSIONis returned to ensure this behavior doesn’t regress.
return MONOREPO_ELECTRON_CHROMIUM_VERSION;
packages/compass-e2e-tests/helpers/compass.ts:476
- [nitpick] Add a JSDoc comment to explain that this function falls back to
MONOREPO_ELECTRON_CHROMIUM_VERSIONwhen parsing the--versionsoutput fails.
async function getChromiumVersionFromBinary(path: string) {
lerouxb
force-pushed
the
fallback-old-binaries
branch
from
59b48fe to
9a65a9b
Compare
mabaasit
approved these changes
Jul 14, 2025
gribnoysup
approved these changes
Jul 15, 2025
Contributor
Author
|
This does exactly what it should, but I'm pretty sure it is still not working when we cross electron versions. Probably because we start off on one and then end on the other and we don't re-start/re-launch the e2e tests in between. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7108